[GC] Add all basic types to SubTypes::getMaxDepths#8216
Merged
kripken merged 7 commits intoWebAssembly:mainfrom Jan 21, 2026
Merged
[GC] Add all basic types to SubTypes::getMaxDepths#8216kripken merged 7 commits intoWebAssembly:mainfrom
kripken merged 7 commits intoWebAssembly:mainfrom
Conversation
tlively
approved these changes
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caused a miscompilation in GUFA: when a basic type was not present,
we'd not find an entry for its size, which meant
map[type]returned thedefault value - which was 0. 0 is right 99% of the time, except for
ext, whichhas a subtype (
string).Add all the subtypes, and assert in GUFA on entries always existing, which
would have caught this bug.